[PATCH] D46886: Escape ]]> in xunit xml output

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: utils/lit/tests/xunit-output.py:2
 # Check xunit output
 # RUN: %{lit} --xunit-xml-output %t.xunit.xml %{inputs}/xunit-output || true
+# If xmllint is installed verify that the generated xml is well-formed
----------------
@cmatthews 
Wait. I know this isn't part of the patch but what's that `|| true` doing there? That's ignoring the exit code of `lit`. Do we really want to do that?


Repository:
  rL LLVM

https://reviews.llvm.org/D46886