[PATCH] D46883: [llvm-exegesis] Analysis: Display sched class for instructions.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet requested changes to this revision.
gchatelet added inline comments.
This revision now requires changes to proceed.


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:70
+    : Clustering_(Clustering) {
+  if (Clustering.getPoints().empty())
+    return;
----------------
`assert(Target);`?


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:97
   // Write the points.
-  for (size_t I = 0, E = Clustering.getValidClusters().size(); I < E; ++I) {
-    printCluster(Clustering.getPoints(), STI, I,
-                 Clustering.getValidClusters()[I], OS);
+  for (size_t I = 0, E = Clustering_.getValidClusters().size(); I < E; ++I) {
+    for (const size_t PointId :
----------------
A variable for `Clustering_.getValidClusters()` would help readability.


================
Comment at: tools/llvm-exegesis/lib/Analysis.h:29
 
-// Prints a csv of instructions for each cluster.
-llvm::Error
-printAnalysisClusters(const InstructionBenchmarkClustering &Clustering,
-                      const llvm::MCSubtargetInfo &STI, llvm::raw_ostream &OS);
+class Analysis {
+public:
----------------
Doc?


Repository:
  rL LLVM

https://reviews.llvm.org/D46883