[PATCH] D46843: Rename three cxx files in unittests to cpp.
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 15 07:32:13 PDT 2018
thakis added a comment.
In https://reviews.llvm.org/D46843#1099361, @philip.pfaffe wrote:
> In https://reviews.llvm.org/D46843#1099354, @thakis wrote:
>
> > That's how `svn diff` looks after `svn mv`. Maybe you use git (which doesn't have a native "move file" operation) and aren't used to seeing this type of diff?
>
>
> I'm not sure what caused it, but the patch is not applicable.
I used the command that https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface tells me to use. As far as I know, `svn diff` doesn't produce diffs that apply for `svn mv` changes. It'll commit ok.
https://reviews.llvm.org/D46843
More information about the llvm-commits
mailing list