[PATCH] D46821: Update llvm-exegesis to cover latency through another opcode.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/MCInstrDescView.cpp:154
+  static std::random_device RandomDevice;
+  static std::mt19937 RandomGenerator(RandomDevice());
+  return RandomGenerator;
----------------
courbet wrote:
> let's seed with a flag or a constexpr (unittests will thank you).
Added a FIXME, I'll do this in a follow up patch.


================
Comment at: tools/llvm-exegesis/lib/MCInstrDescView.h:127
+// it and set the target Variables to the selected values.
+void setRandomAliasing(const AliasingConfigurations &AliasingConfigurations);
+
----------------
courbet wrote:
> ```
> AliasingConfigurations AliasingConfigurations::createRandomAssignment(const AliasingConfigurations &AliasingConfigurations);
> ```
> 
Added a FIXME, I'll do it in a follow up patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D46821