[llvm] r322325 - PeepholeOpt cleanup/refactor; NFC

[Dimitry Andric via llvm-commits]

On 11 Jan 2018, at 23:59, Matthias Braun via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: matze
> Date: Thu Jan 11 14:59:33 2018
> New Revision: 322325
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=322325&view=rev
> Log:
> PeepholeOpt cleanup/refactor; NFC
> 
> - Less unnecessary use of `auto`
> - Add early `using RegSubRegPair(AndIdx) =` to avoid countless
>  `TargetInstrInfo::` qualifications.
> - Use references instead of pointers where possible.
> - Remove unused parameters.
> - Rewrite the CopyRewriter class hierarchy:
>   - Pull out uncoalescable copy rewriting functionality into
>     PeepholeOptimizer class.
>   - Use an abstract base class to make it clear that rewriters are
>     independent.
> - Remove unnecessary \brief in doxygen comments.
> - Remove unused constructor and method from ValueTracker.
> - Replace UseAdvancedTracking of ValueTracker with DisableAdvCopyOpt use.

Hi Matthias,

Even though your commit message says "NFC", apparently this commit fixes a runaway compiler bug in godot:

https://github.com/godotengine/godot/issues/18023

I haven't verified this yet, but 1) do you think that is possible, and 2) if it does fix a bug, should we merge it into 6.0.1?

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180515/bd23a31f/attachment.sig>