[PATCH] D46754: [AMDGPU] Add intrinsics for 16 bit interpolation

[Tim Corringham via Phabricator via llvm-commits]

timcorringham added inline comments.


================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:1070
 // __builtin_amdgcn_interp_p2 <p1>, <j>, <attr_chan>, <attr>, <m0>
 def int_amdgcn_interp_p2 :
   GCCBuiltin<"__builtin_amdgcn_interp_p2">,
----------------
arsenm wrote:
> You should add name mangling to the existing intrinsics rather than new intrinsics. The builtin declaration needs to be done in clang for the GCCBuiltin
I now have the clang changes in D46871 (I have added the 32 bit interp builtins too as they were missing).

I don't believe it is possible to overload these intrinsics as they have an extra operand compared to the 32 bit versions. Also apart from the extra operand the signature of the 16 bit p1 intrinsic is identical to the 32 bit one, so there iosn't any type difference to overload. 


Repository:
  rL LLVM

https://reviews.llvm.org/D46754