[PATCH] D46839: [lld] Make ALIGN work with -r in linker scripts

[Mark Kettenis via Phabricator via llvm-commits]

kettenis added inline comments.


================
Comment at: test/ELF/linkerscript/align.s:45
 
+## Check output sections ALIGN modificator with -r
+# RUN: echo "SECTIONS {                    \
----------------
jhenderson wrote:
> Nit: modificator -> modifier or expression
What can I say; just copy and pasted it from the existing example. Want me to cange that one too?


================
Comment at: test/ELF/linkerscript/align.s:51
+# RUN:  .ccc : ALIGN(4096 * 4) { *(.ccc) } \
+# RUN: }" > %t6.script
+# RUN: ld.lld -r -o %t2 --script %t2.script %t
----------------
grimar wrote:
> This script has no differences from the script right above on lines 35-41.
> Hence you do not need it. And actually, you do not use it.
Right. I'll remove that one and change the command slightly such that it doesn't overwrite the output of the previous test.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46839