[PATCH] D46865: [llvm-exegesis] Add an analysis mode.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet requested changes to this revision.
gchatelet added inline comments.
This revision now requires changes to proceed.


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:20
+                         const size_t ClusterId, llvm::raw_ostream &OS) {
+  OS << ClusterId << ";" << Point.AsmTmpl.Name;
+  // FIXME: Print the sched class once InstructionBenchmark separates key into
----------------
Technically CSV is **comma** separated and not semicolon separated.
Semicolon seems to be a popular variant in French but not necessarily in other locales.
Also strings should be quoted to prevent interpretation of comma (semicolon) within them.


================
Comment at: tools/llvm-exegesis/lib/Clustering.cpp:22
 //  (D) - The number of clusters is not known /a priory/.
-//  (E) - The amount of noise is relatively small.
+//  (E) - The amoint of noise is relatively small.
 // The problem is rather small. In terms of algorithms, (D) disqualifies
----------------
?


Repository:
  rL LLVM

https://reviews.llvm.org/D46865