[PATCH] D46843: Rename three cxx files in unittests to cpp.

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 15 00:06:09 PDT 2018


philip.pfaffe added a comment.

Something is off with the diff. E.g. the file `TestPlugin.cpp` doesn't exist, yet the diff contains modifications. Did you miss a local commit?



================
Comment at: unittests/Passes/CMakeLists.txt:1
+# Hack to bypass LLVM's CMake source checks so we can have both a library and
+# an executable built from this directory.
----------------
It's not a hack, but the purpose of that setting. So just document the intent directly.


https://reviews.llvm.org/D46843





More information about the llvm-commits mailing list