[PATCH] D46809: [GlobalISel] NFCI, Getting GlobalISel ~5% faster

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

This is pretty non-invasive, so code LGTM aside from one minor stylistic comment on an assertion. I would wait for comments from another reviewer though, since I'm not super familiar with this particular bit of code.

It'd also be nice to just see the high level results of a CTMark run if possible? I love the in-depth data analysis here, but I think it would be nice to have a couple more data points just to make sure there are no regressions.



================
Comment at: lib/CodeGen/GlobalISel/InstructionSelect.cpp:205
+          MF, TPC, MORE, "gisel-select",
+          "VReg has a low-level type and a regclass of different sizes", *MI);
       return false;
----------------
Maybe something like "VReg's low-level type and register class have different sizes" would be a bit more concise?


Repository:
  rL LLVM

https://reviews.llvm.org/D46809