[PATCH] D46858: Signal handling should be signal-safe
Steven Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 14 18:46:57 PDT 2018
steven_wu added a comment.
I think it is easier to unregister all the signal handlers in the beginning of the llvm_shutdown() since you should be done with all the work when you call llvm_shutdown(). This can also allow safe access ManagedStatics in signal handler, which I don't know if we have more of those other than the lock you are trying to fix. The only difference might be that if an interrupt is triggered when freeing ManagedStatics, llvm signal handler will not be used.
Repository:
rL LLVM
https://reviews.llvm.org/D46858
More information about the llvm-commits
mailing list