[PATCH] D46785: [msan] Instrument masked.store, masked.load intrinsics.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2595
+      if (PropagateShadow) {
+	// Choose between PassThru's and the loaded value's origins.
+        Value *MaskedPassThruShadow = IRB.CreateAnd(
----------------
align the comment


================
Comment at: llvm/test/Instrumentation/MemorySanitizer/masked-store-load.ll:1
+; RUN: opt < %s -msan -msan-check-access-address=0 -S | FileCheck %s
+; RUN: opt < %s -msan -msan-check-access-address=0 -msan-track-origins=1 -S | FileCheck %s --check-prefixes=CHECK,CHECK-ORIGIN
----------------
don't you need a test for the !PropagateShadow and ClCheckAccessAddress cases? 


https://reviews.llvm.org/D46785