[PATCH] D46707: [DWARF] Factor out a DWARFUnitHeader class. NFC

[Paul Robinson via Phabricator via llvm-commits]

probinson marked an inline comment as done.
probinson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:114-116
+    // Fake a unit type based on the section type.  This isn't perfect,
+    // but to do better we'd need to look at the unit DIE.  The crucial
+    // distinction is type unit or not, because the header differs.
----------------
dblaikie wrote:
> Not sure this comment makes sense - you can't look at the unit DIE, right? Because you have to parse the header before you parse the DIEs, so that doesn't seem like a relevant suggestion/approach here?
Fair.  Changed the comment to avoid the suggestion.


https://reviews.llvm.org/D46707