[PATCH] D46265: StackColoring: better handling of statically unreachable code

[Than McIntosh via Phabricator via llvm-commits]

thanm added a comment.

In https://reviews.llvm.org/D46265#1097769, @sdardis wrote:

> I've tried the revised patch, but I am still seeing flakiness when running this on my darwin machine.


OK, got it. Sounds like the test case still needs more work.

I am traveling this week and don't have access to a darwin machine, but I should be able to test that scenario when I get back.

> It appears CodeGenPrepare::eliminateMostlyEmptyBlock is leaving around stale information that is then read by the MIRPrintingPass.
> 
> I have a suggestion inline, and with that, the change to UnreachableBlockElim.cpp seems unnecessary. Can you also test on your side?

Will do.


Repository:
  rL LLVM

https://reviews.llvm.org/D46265