[llvm] r332280 - Inline a few CMake variables into their only uses.

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Mon May 14 12:23:31 PDT 2018


Author: nico
Date: Mon May 14 12:23:31 2018
New Revision: 332280

URL: http://llvm.org/viewvc/llvm-project?rev=332280&view=rev
Log:
Inline a few CMake variables into their only uses.

No behavior change. Makes unittests CMakeLists.txt files more self-consistent.


Modified:
    llvm/trunk/unittests/ADT/CMakeLists.txt
    llvm/trunk/unittests/CodeGen/CMakeLists.txt
    llvm/trunk/unittests/DebugInfo/CodeView/CMakeLists.txt
    llvm/trunk/unittests/DebugInfo/DWARF/CMakeLists.txt
    llvm/trunk/unittests/DebugInfo/MSF/CMakeLists.txt
    llvm/trunk/unittests/DebugInfo/PDB/CMakeLists.txt
    llvm/trunk/unittests/Demangle/CMakeLists.txt
    llvm/trunk/unittests/IR/CMakeLists.txt
    llvm/trunk/unittests/Linker/CMakeLists.txt
    llvm/trunk/unittests/XRay/CMakeLists.txt

Modified: llvm/trunk/unittests/ADT/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/CMakeLists.txt (original)
+++ llvm/trunk/unittests/ADT/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -2,7 +2,7 @@ set(LLVM_LINK_COMPONENTS
   Support
   )
 
-set(ADTSources
+add_llvm_unittest(ADTTests
   APFloatTest.cpp
   APIntTest.cpp
   APSIntTest.cpp
@@ -65,10 +65,6 @@ set(ADTSources
   TripleTest.cpp
   TwineTest.cpp
   VariadicFunctionTest.cpp
- )
-
-add_llvm_unittest(ADTTests
-  ${ADTSources}
   )
 
 add_dependencies(ADTTests intrinsics_gen)

Modified: llvm/trunk/unittests/CodeGen/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/CodeGen/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/CodeGen/CMakeLists.txt (original)
+++ llvm/trunk/unittests/CodeGen/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -8,7 +8,7 @@ set(LLVM_LINK_COMPONENTS
   Target
   )
 
-set(CodeGenSources
+add_llvm_unittest(CodeGenTests
   DIEHashTest.cpp
   LowLevelTypeTest.cpp
   MachineInstrBundleIteratorTest.cpp
@@ -17,8 +17,4 @@ set(CodeGenSources
   ScalableVectorMVTsTest.cpp
   )
 
-add_llvm_unittest(CodeGenTests
-  ${CodeGenSources}
-  )
-
 add_subdirectory(GlobalISel)

Modified: llvm/trunk/unittests/DebugInfo/CodeView/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/CodeView/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/DebugInfo/CodeView/CMakeLists.txt (original)
+++ llvm/trunk/unittests/DebugInfo/CodeView/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -2,14 +2,10 @@ set(LLVM_LINK_COMPONENTS
   DebugInfoCodeView
   )
 
-set(DebugInfoCodeViewSources
+add_llvm_unittest(DebugInfoCodeViewTests
   RandomAccessVisitorTest.cpp
   TypeHashingTest.cpp
   TypeIndexDiscoveryTest.cpp
   )
 
-add_llvm_unittest(DebugInfoCodeViewTests
-  ${DebugInfoCodeViewSources}
-  )
-
 target_link_libraries(DebugInfoCodeViewTests PRIVATE LLVMTestingSupport)

Modified: llvm/trunk/unittests/DebugInfo/DWARF/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/DWARF/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/DebugInfo/DWARF/CMakeLists.txt (original)
+++ llvm/trunk/unittests/DebugInfo/DWARF/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -8,7 +8,7 @@ set(LLVM_LINK_COMPONENTS
   Support
   )
 
-set(DebugInfoSources
+add_llvm_unittest(DebugInfoDWARFTests
   DwarfGenerator.cpp
   DwarfUtils.cpp
   DWARFDebugInfoTest.cpp
@@ -16,8 +16,4 @@ set(DebugInfoSources
   DWARFFormValueTest.cpp
   )
 
-add_llvm_unittest(DebugInfoDWARFTests
-  ${DebugInfoSources}
-  )
-
 target_link_libraries(DebugInfoDWARFTests PRIVATE LLVMTestingSupport)

Modified: llvm/trunk/unittests/DebugInfo/MSF/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/MSF/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/DebugInfo/MSF/CMakeLists.txt (original)
+++ llvm/trunk/unittests/DebugInfo/MSF/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -2,14 +2,10 @@ set(LLVM_LINK_COMPONENTS
   DebugInfoMSF
   )
 
-set(DebugInfoMSFSources
+add_llvm_unittest(DebugInfoMSFTests
   MappedBlockStreamTest.cpp
   MSFBuilderTest.cpp
   MSFCommonTest.cpp
   )
 
-add_llvm_unittest(DebugInfoMSFTests
-  ${DebugInfoMSFSources}
-  )
-
 target_link_libraries(DebugInfoMSFTests PRIVATE LLVMTestingSupport)

Modified: llvm/trunk/unittests/DebugInfo/PDB/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/PDB/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/DebugInfo/PDB/CMakeLists.txt (original)
+++ llvm/trunk/unittests/DebugInfo/PDB/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -4,14 +4,10 @@ set(LLVM_LINK_COMPONENTS
   DebugInfoPDB
   )
 
-set(DebugInfoPDBSources
+add_llvm_unittest(DebugInfoPDBTests
   HashTableTest.cpp
   StringTableBuilderTest.cpp
   PDBApiTest.cpp
   )
 
-add_llvm_unittest(DebugInfoPDBTests
-  ${DebugInfoPDBSources}
-  )
-
 target_link_libraries(DebugInfoPDBTests PRIVATE LLVMTestingSupport)

Modified: llvm/trunk/unittests/Demangle/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Demangle/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/Demangle/CMakeLists.txt (original)
+++ llvm/trunk/unittests/Demangle/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -2,10 +2,6 @@ set(LLVM_LINK_COMPONENTS
   Demangle
 )
 
-set(DemangleSources
-  PartialDemangleTest.cpp
-)
-
 add_llvm_unittest(DemangleTests
-  ${DemangleSources}
+  PartialDemangleTest.cpp
 )

Modified: llvm/trunk/unittests/IR/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/IR/CMakeLists.txt (original)
+++ llvm/trunk/unittests/IR/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -6,7 +6,7 @@ set(LLVM_LINK_COMPONENTS
   Passes
   )
 
-set(IRSources
+add_llvm_unittest(IRTests
   AsmWriterTest.cpp
   AttributesTest.cpp
   BasicBlockTest.cpp
@@ -40,7 +40,3 @@ set(IRSources
   VerifierTest.cpp
   WaymarkTest.cpp
   )
-
-add_llvm_unittest(IRTests
-  ${IRSources}
-  )

Modified: llvm/trunk/unittests/Linker/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Linker/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/Linker/CMakeLists.txt (original)
+++ llvm/trunk/unittests/Linker/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -4,10 +4,6 @@ set(LLVM_LINK_COMPONENTS
   linker
   )
 
-set(LinkerSources
-  LinkModulesTest.cpp
-  )
-
 add_llvm_unittest(LinkerTests
-  ${LinkerSources}
+  LinkModulesTest.cpp
   )

Modified: llvm/trunk/unittests/XRay/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/XRay/CMakeLists.txt?rev=332280&r1=332279&r2=332280&view=diff
==============================================================================
--- llvm/trunk/unittests/XRay/CMakeLists.txt (original)
+++ llvm/trunk/unittests/XRay/CMakeLists.txt Mon May 14 12:23:31 2018
@@ -2,12 +2,8 @@ set(LLVM_LINK_COMPONENTS
   Support
   )
 
-set(XRAYSources
- GraphTest.cpp
- )
-
 add_llvm_unittest(XRayTests
-    ${XRAYSources}
+  GraphTest.cpp
   )
 
 add_dependencies(XRayTests intrinsics_gen)




More information about the llvm-commits mailing list