[PATCH] D46830: [llvm-objcopy] Add --keep-file-symbols option

Paul Semel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 14 09:35:17 PDT 2018


paulsemel added a comment.

In https://reviews.llvm.org/D46830#1098085, @jhenderson wrote:

> Other than explicitly stripping the file symbol, is there any way of actually removing such symbols currently? It seems like adding a switch just to prevent you doing something you asked for is a bit superfluous.
>
> Do you have a specific use-case at the moment?


Well, `--strip-unneeded` can trigger the file symbols removal. Anyway, for the moment, I stopped implementing it because I have some problems with the error messages we are issuing for the symbol removal.

In all cases, I truly think that this way is the way to prevent from file symbol removal (particularly for the `--strip-unneeded` option). Maybe I can just remove the section removal test and land it like this, waiting for someone (maybe me) to implement `--strip-unneeded` and to add a better test case ?

What do you think about it ?


Repository:
  rL LLVM

https://reviews.llvm.org/D46830





More information about the llvm-commits mailing list