[PATCH] D46818: [llvm-rc] Add support for parsing memory flags

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 14 09:22:34 PDT 2018


amccarth added a comment.

I kinda wish the test was broken up a bit.  The stringtable bundle logic is distinctly different than just applying the keywords to other resource types, so that would be a natural place to break this apart.

The changes themselves seem correct.


Repository:
  rL LLVM

https://reviews.llvm.org/D46818





More information about the llvm-commits mailing list