[PATCH] D45315: [X86] Improve unsigned saturation downconvert detection.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 14 08:59:06 PDT 2018
RKSimon added a comment.
In https://reviews.llvm.org/D45315#1097913, @ArturGainullin wrote:
> Simon, thanks! I agree that operands have same type. Do you think that it is better to create new node? Or the latest uploaded version where I update the operand of smax is acceptable?
>
> DAG.UpdateNodeOperands(In.getNode(), SMin, In.getOperand(1));
> return In;
>
A new node is clearer and avoids issues if In is used multiple times.
Repository:
rL LLVM
https://reviews.llvm.org/D45315
More information about the llvm-commits
mailing list