[llvm] r331792 - DAG: Use correct shift width type

[Matt Arsenault via llvm-commits]

> On May 9, 2018, at 00:46, Friedman, Eli via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> On 5/8/2018 11:43 AM, Matt Arsenault via llvm-commits wrote:
>> Author: arsenm
>> Date: Tue May  8 11:43:05 2018
>> New Revision: 331792
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=331792&view=rev
>> Log:
>> DAG: Use correct shift width type
>> 
>> Modified:
>>     llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
>> 
>> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp?rev=331792&r1=331791&r2=331792&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp Tue May  8 11:43:05 2018
>> @@ -1076,7 +1076,7 @@ SDValue DAGTypeLegalizer::JoinIntegers(S
>>    Hi = DAG.getNode(ISD::ANY_EXTEND, dlHi, NVT, Hi);
>>    Hi = DAG.getNode(ISD::SHL, dlHi, NVT, Hi,
>>                     DAG.getConstant(LVT.getSizeInBits(), dlHi,
>> -                                   TLI.getPointerTy(DAG.getDataLayout())));
>> +                                   TLI.getShiftAmountTy(NVT, DAG.getDataLayout())));
> 
> Should this be "TLI.getShiftAmountTy(NVT, DAG.getDataLayout(), false)"?
> 
> -Eli

I’m not sure. I don’t really understand what the point of that option is. This is during type legalization, so maybe it should be producing a legal shift type?

-Matt