[PATCH] D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC)

[Will Wilson via Phabricator via llvm-commits]

lantictac added a comment.

A few issues. On the DOS command-line I can shoehorn in some escaped double-quotes using /manifestuac:"level='asInvoker' uiAccess=""false""" and still generate a PDB. However:

1. I can't figure out a way to get the test runner to pass the escaped double-quotes during testing. It either mangles the command-line or the double-quotes are ignored. Only directly running under cmd.exe seems to work.
2. I'm still not convinced anyone would ever encounter an escaped double-quote in a link.exe command-line IRL. Although, feel free to come up with a realistic example I haven't thought of.
3. I'm not sure if escaping double-quotes as "" would be the best method of escaping the quote since this appears to be specific to the the Command Prompt parsing rules (and MSVC offers no standard approach).
4. As pcc points out MSVC link.exe doesn't escape these inner double-quotes anyhow.
5. The link command-line stored in the PDB unlikely to matter to the vast majority of users.

In short, I can't really afford much more time on this unless anyone can resolve/answer/workaround a few of the issues above. Any thoughts?


https://reviews.llvm.org/D46427