[PATCH] D46748: [CodeGen/AccelTable]: Handle -dwarf-linkage-names=Abstract correctly

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In https://reviews.llvm.org/D46748#1097654, @JDevlieghere wrote:

> I meant for the missing `++NumErrors;`. But on checking the existing test (`debug-names-verify-entries.s`) we already check the return value, which just happens to be non-zero because of the other failures. I'm okay with keeping it as is.


Ah, right. I though about that too. The only way to test that thoroughly would be to split each check into a separate test case, which checks only one kind of an error, but that seemed very inconvenient. I guess the right fix here would be to change the verifier interface to make it harder/impossible to report an "error" without affecting the overall return value.

Thanks for the review.


Repository:
  rL LLVM

https://reviews.llvm.org/D46748