[PATCH] D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h:299
+    LineTable parseNext(
+        function_ref<void(StringRef)> StringCallback = warn,
+        function_ref<void(Error)> ErrorCallback = warnForError,
----------------
JDevlieghere wrote:
> Why not have both callbacks take an `Error`? I consider one a recoverable error and the other a non-recoverable error. It would be nice if both use the same "warn" callback by default?
That's a good suggestion, thanks. I'll create a new review shortly with that change.


Repository:
  rL LLVM

https://reviews.llvm.org/D44560