[PATCH] D46821: Update llvm-exegesis to cover latency through another opcode.

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Assembler.cpp:16
 
-static constexpr const char ModuleID[] = "ExegesisInfoTest";
-static constexpr const char FunctionID[] = "foo";
+namespace {
+
----------------
Please keep the `static`s: https://llvm.org/docs/CodingStandards.html#anonymous-namespaces


================
Comment at: tools/llvm-exegesis/lib/Assembler.h:43
+
+struct AssemblerFunction {
+  explicit AssemblerFunction(std::unique_ptr<llvm::LLVMTargetMachine> TM);
----------------
doc ?


================
Comment at: tools/llvm-exegesis/lib/Assembler.h:57
+
+llvm::object::OwningBinary<llvm::object::ObjectFile>
+getObjectFromBuffer(llvm::StringRef Buffer);
----------------
doc ?


================
Comment at: tools/llvm-exegesis/lib/Assembler.h:61
+llvm::object::OwningBinary<llvm::object::ObjectFile>
+getObjectFromFile(llvm::StringRef Filename);
+
----------------
doc ?


================
Comment at: tools/llvm-exegesis/lib/Assembler.h:63
+
+struct ExecutableFunction {
+  explicit ExecutableFunction(
----------------
doc ?


Repository:
  rL LLVM

https://reviews.llvm.org/D46821