[PATCH] D46819: [llvm-objcopy] Add --keep-symbol (-K) option

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM with the suggested comments.



================
Comment at: test/tools/llvm-objcopy/keep-symbol-remove-section.test:2
+# RUN: yaml2obj %s > %t
+# RUN: llvm-objcopy --remove-section .text -K foo %t %t2
+# RUN: llvm-readobj -symbols %t2 | FileCheck %s
----------------
Nit: I'd suggest using only long options in this sort of test, to make it a little clearer.


================
Comment at: test/tools/llvm-objcopy/keep-symbol.test:3
+# RUN: llvm-objcopy -x -K foo --keep-symbol bar %t %t2
+# RUN: llvm-objcopy -N foo -K foo -N bar --keep-symbol bar -N baz %t %t3
+# RUN: llvm-readobj -symbols %t2 | FileCheck %s
----------------
Could you make this "-K foo -N foo -N bar --keep-symbol bar -N baz" or similar, to show that order doesn't matter, please?


Repository:
  rL LLVM

https://reviews.llvm.org/D46819