[PATCH] D46369: [llvm-objcopy] Add --strip-symbol (-N) option

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon May 14 01:16:40 PDT 2018


Hi Paul,

I just wanted to point out this section from the LLVM docs, which you might
find helpful: https://llvm.org/docs/Phabricator.html#committing-a-change

In particular, if you add "Differential Revision: <Phabricator review URL>"
to the commit message, it will automatically close the revision, and add a
comment saying which commit did so. You can see one of my recent commits,
r331972 for an example of this.

Regards,

James

On 11 May 2018 at 21:02, Paul Semel via Phabricator <
reviews at reviews.llvm.org> wrote:

> paulsemel closed this revision.
> paulsemel added a comment.
>
> In https://reviews.llvm.org/D46369#1096333, @jakehehrlich wrote:
>
> > Ping. Do you need anything else from one of us?
>
>
> I'm sorry, this patch has been push 2 days ago, just forgot to close the
> revision.. my bad :)
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D46369
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180514/d8d5add6/attachment.html>


More information about the llvm-commits mailing list