[PATCH] D44011: [LNT] Make new Order template in Compare To in v4_run.html view.

[Martin Liška via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL332218: Make new Run template in Compare To in v4_run.html view. (authored by marxin, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D44011?vs=140759&id=146546#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D44011

Files:
  lnt/trunk/lnt/server/ui/templates/local.html
  lnt/trunk/lnt/server/ui/templates/v4_run.html


Index: lnt/trunk/lnt/server/ui/templates/v4_run.html
===================================================================
--- lnt/trunk/lnt/server/ui/templates/v4_run.html
+++ lnt/trunk/lnt/server/ui/templates/v4_run.html
@@ -1,4 +1,5 @@
 {% import "utils.html" as utils %}
+{% import "local.html" as local %}
 
 {% set hash_field = ts.Sample.get_hash_of_binary_field() %}
 {% set machine = run.machine %}
@@ -114,7 +115,7 @@
   {% for r in neighboring_runs %}
     <li>
       {{ "<b>"|safe if r.id == run.id else "" }}
-      <a href="{{v4_url_for('.v4_run', id=r.id)}}"><span class="utctime">{{ r.start_time.isoformat() }}</span></a>
+      {{ local.render_compare_to_run(r, v4_url_for('.v4_run', id=r.id)) }}
       {{ "</b>"|safe if r.id == run.id else "" }}
     </li>
   {% endfor %}
@@ -126,7 +127,7 @@
     {% for r in comparison_neighboring_runs %}
       <li>
         {{ "<b>"|safe if compare_to and r.id == compare_to.id else "" }}
-        <a href="{{v4_url_for('.v4_run', id=run.id, compare_to=r.id)}}"><span class="utctime">{{ r.start_time.isoformat() }}</span></a>
+        {{ local.render_compare_to_run(r, v4_url_for('.v4_run', id=run.id, compare_to=r.id)) }}
         {{ "</b>"|safe if compare_to and r.id == compare_to.id else "" }}
       </li>
     {% endfor %}
Index: lnt/trunk/lnt/server/ui/templates/local.html
===================================================================
--- lnt/trunk/lnt/server/ui/templates/local.html
+++ lnt/trunk/lnt/server/ui/templates/local.html
@@ -7,6 +7,10 @@
     <a href="{{v4_url_for('.v4_order', id=order.id)}}">{{ prefix }}{{order.llvm_project_revision}}</a>
 {%- endmacro %}
 
+{% macro render_compare_to_run(run, url) -%}
+<a href="{{url}}"><span class="utctime">{{ run.start_time.isoformat() }}</span></a>
+{%- endmacro %}
+
 {# Some example settings from llvm.org. #}
 {#
     <!---On llvm.org we use SVN, so put an r in front. Ex. r1234 -->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44011.146546.patch
Type: text/x-patch
Size: 1910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180514/00c0b200/attachment.bin>