[LNT] r332217 - Make Run-Over-Run and Run-Over-Baseline changes an accordion.

[Martin Liska via llvm-commits]

Author: marxin
Date: Mon May 14 00:43:55 2018
New Revision: 332217

URL: http://llvm.org/viewvc/llvm-project?rev=332217&view=rev
Log:
Make Run-Over-Run and Run-Over-Baseline changes an accordion.

Differential Revision: https://reviews.llvm.org/D44013


Modified:
    lnt/trunk/lnt/server/ui/templates/reporting/runs.html
    lnt/trunk/lnt/server/ui/templates/utils.html

Modified: lnt/trunk/lnt/server/ui/templates/reporting/runs.html
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/reporting/runs.html?rev=332217&r1=332216&r2=332217&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/templates/reporting/runs.html (original)
+++ lnt/trunk/lnt/server/ui/templates/reporting/runs.html Mon May 14 00:43:55 2018
@@ -160,19 +160,27 @@
   </tfoot>
 </table>
 
-<p>
-<h3>Run-Over-Run Changes Detail</h3>
-{% for _, field, bucket_name, sorted_bucket, test_names, show_perf in prioritized_buckets_run_over_run %}
-  {% set field_index = ts.get_field_index(field) %}
-  {{
-    add_report_changes_detail_for_field_and_bucket(compare_to, field, show_perf, run_url, field_index, field.display_name,
-                                                   bucket_name, sorted_bucket, test_names,
-                                                   'Previous', '', ' (B)', run_to_baseline_info, styles, classes)
-  }}
-{% endfor %}
-</p>
+
+<section id="run_over_run">
+  {{ utils.render_popup_begin('run_over_run', 'Run-Over-Run Changes Detail', false, 'h3') }}
+    <p>
+    {% for _, field, bucket_name, sorted_bucket, test_names, show_perf in prioritized_buckets_run_over_run %}
+      {% set field_index = ts.get_field_index(field) %}
+      {{
+        add_report_changes_detail_for_field_and_bucket(compare_to, field, show_perf, run_url, field_index, field.display_name,
+                                                       bucket_name, sorted_bucket, test_names,
+                                                       'Previous', '', ' (B)', run_to_baseline_info, styles, classes)
+      }}
+    {% endfor %}
+    </p>
+  {{ utils.render_popup_end() }}
+</section>
+
+
+<section id="run_over_baseline">
+  {{ utils.render_popup_begin('run_over_baseline', 'Run-Over-Baseline Changes Detail', false, 'h3') }}
+    <p>
 {% if baseline %}
-<h3>Run-Over-Baseline Changes Detail</h3>
 {% for _, field, bucket_name, sorted_bucket, test_names, show_perf in prioritized_buckets_run_over_baseline %}
   {% set field_index = ts.get_field_index(field) %}
   {{
@@ -182,5 +190,9 @@
   }}
 {% endfor %}
 {% endif %}
+    </p>
+  {{ utils.render_popup_end() }}
+</section>
+
 <hr/>
 <b>Report Time</b>: {{ start_time | timedelta }}

Modified: lnt/trunk/lnt/server/ui/templates/utils.html
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/utils.html?rev=332217&r1=332216&r2=332217&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/templates/utils.html (original)
+++ lnt/trunk/lnt/server/ui/templates/utils.html Mon May 14 00:43:55 2018
@@ -1,8 +1,8 @@
-{% macro render_popup_begin(id, title, hidden, depth=1) -%}
+{% macro render_popup_begin(id, title, hidden, element = 'span', depth=1) -%}
   <div class="accordion" id="{{id}}-accordion">
     <div class="accordion-group">
       <div class="accordion-heading">
-        <a class="accordion-toggle" data-toggle="collapse" data-parent="#{{id}}-accordion" href="#{{id}}-collapse">{{ title }}</a>
+          <{{element}}><a class="accordion-toggle" data-toggle="collapse" data-parent="#{{id}}-accordion" href="#{{id}}-collapse">{{ title }}</a></{{element}}>
       </div>
       <div id="{{id}}-collapse" class="accordion-body {{ 'collapse' if hidden else 'collapse in' }}">
         <div class="accordion-inner">