[PATCH] D46813: [llvm-rc] Add missing inputs for tag-icon-cursor.test.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 13 14:04:30 PDT 2018


mstorsjo added inline comments.


================
Comment at: test/tools/llvm-rc/tag-icon-cursor.test:159
 ; CHECK-NEXT: Data: (
-; CHECK-NEXT:   0000: 00000100 04001010 00000100 20006804  |............ .h.|
+; CHECK-NEXT:   0000: 00000100 04001010 00000100 00006804  |..............h.|
 ; CHECK-NEXT:   0010: 00000300 18180000 01002000 88090000  |.......... .....|
----------------
FWIW, the previous value here seems to be what rc.exe produces, so something is wrong in the current codebase. But improving the test coverage for the current code as it stands probably also is worthwhile, even if there are known issues?


Repository:
  rL LLVM

https://reviews.llvm.org/D46813





More information about the llvm-commits mailing list