[PATCH] D46525: [Debugify] Introduce debugify-each and DebugifyFunctionPass

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 12 10:46:49 PDT 2018


vsk accepted this revision as: vsk.
vsk added a comment.
This revision is now accepted and ready to land.

LGTM. If you don’t have commit access, let me know, and I can commit this for you on Monday.

In https://reviews.llvm.org/D46525#1096844, @tyb0807 wrote:

> Sorry it was a local change, forgot to remove it before `diff`ing. Please tell me if there's any way to handle local change while still being able to create patch properly.


No problem. If you use git, you can use “git -p” to selectively stage changes, commit them locally, and then “git stash” any remaining changes which shouldn’t be in the diff.

> So do you need anything else (even if it is not in `debugify`)? I am willing to help!

Thanks again for your help. There’s certainly more to do. Some ideas:

- Extend the -verify-each mode in opt, so that it also is enabled after each module/function pass.
- Run opt -O1 with -debugify-each on input .ll files generated from clang, and see if you can find/fix debug info loss bugs.

Others in the community will have more ideas, so it’s worth asking around on IRC or LLVM-dev.


Repository:
  rL LLVM

https://reviews.llvm.org/D46525





More information about the llvm-commits mailing list