grimar added inline comments. ================ Comment at: ELF/ICF.cpp:426 + } else + warn("Could not find symbol " + Name + " to keep unique"); + } ---------------- We usually start warnings and errors from the lower case character. https://reviews.llvm.org/D46755