[PATCH] D46764: Fix test cases that check addresses that are not always invariable

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 12 00:14:06 PDT 2018


grimar added a comment.

Cool that you found the reason! Thanks! I suggest to fix it in a bit different way.

Lets use `-soname` to fix up the name in .dynstr.
I believe that you should be able to resolve this with a change of few invocations only then.
And no need to add additional comments. I think we already used this approach for the same.



================
Comment at: test/ELF/relocation.s:3
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/shared.s -o %t2
 // RUN: ld.lld %t2 -o %t2.so -shared
 // RUN: ld.lld --hash-style=sysv %t %t2.so -o %t3
----------------
Just add a -soname foo.so:

```
ld.lld %t2 -o %t2.so -shared -soname foo.so
```


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46764





More information about the llvm-commits mailing list