[PATCH] D46776: [Option] Fix PR37006 prefix choice in findNearest

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: lib/Option/OptTable.cpp:284
-        Prefix = CandidateInfo.Prefixes[P];
-    }
 
----------------
Shouldn't getting the longest prefix here be good enough? Something like this:

```
StringRef Prefix;
int PrefixLength = 0;
for (int P = 0; Candidateinfo.Prefixes[P]; P++) {
  StringRef Candidate = CandidateInfo.Prefixes[P];
  if (Candiate.size() > PrefixLength && Option.startswith(Candidate)) {
    Prefix = Candidate;
    PrefixLength = Candidate.size();
  }
}
```

…and keep everything else the same?


Repository:
  rL LLVM

https://reviews.llvm.org/D46776