[PATCH] D46525: [Debugify] Introduce debugify-each and DebugifyFunctionPass

[Son Tuan Vu via Phabricator via llvm-commits]

tyb0807 updated this revision to Diff 146430.
tyb0807 marked 13 inline comments as done.
tyb0807 added a comment.

Addressed review comments.

I am thinking about making this work for BasicBlockPass and LoopPass. How can I make an empty range in LLVM (for these passes, function iterator should contain nothing)?

Does something like `make_range(std::next(BB.getParent()->getIterator()), std::next(BB.getParent()->getIterator()))` make sense?

Another question is, what if a `Loop` contains `BasicBlock`s from different `Function`s? I guess we can just pass an empty range for the function iterator parameter, and add another loop over a basic block iterator parameter in `applyDebugifyMetadata` and `checkDebugifyMetadata`.

Thanks again for your help Vedant.


Repository:
  rL LLVM

https://reviews.llvm.org/D46525

Files:
  include/llvm/IR/IRPrintingPasses.h
  lib/IR/IRPrintingPasses.cpp
  test/DebugInfo/debugify-each.ll
  test/DebugInfo/debugify.ll
  test/Transforms/Mem2Reg/PromoteMemToRegister.ll
  tools/opt/Debugify.cpp
  tools/opt/PassPrinters.h
  tools/opt/opt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46525.146430.patch
Type: text/x-patch
Size: 18501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180511/0110662f/attachment.bin>