[PATCH] D38768: Add remarks describing when a pass changes the IR instruction count of a module

[Jessica Paquette via Phabricator via llvm-commits]

paquette updated this revision to Diff 146428.
paquette marked 4 inline comments as done.
paquette added a comment.

Updated diff to address review comments.

- Since we can't use namespace ore here, I kept the `DiagnosticInfoOptimizationBase::Argument` parameters instead of switching them to NV. I'll submit a follow-up patch to resolve this. I added a FIXME explaining what to do here in the meantime.

- All computation for the remarks is now contained in `emitIRSizeChangedRemark`, aside from the initial computation of `InstrCount`. This ensures that we don't count instructions unless we need to.

- General cleanup, etc.


https://reviews.llvm.org/D38768

Files:
  include/llvm/IR/Function.h
  include/llvm/IR/LegacyPassManagers.h
  include/llvm/IR/Module.h
  lib/Analysis/CallGraphSCCPass.cpp
  lib/IR/Function.cpp
  lib/IR/LegacyPassManager.cpp
  lib/IR/Module.cpp
  test/Other/size-remarks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38768.146428.patch
Type: text/x-patch
Size: 14899 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180511/bf1d447d/attachment.bin>