[PATCH] D46773: [lit] Fix several tests that fail when using Python 3 or on Windows

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 11 13:45:18 PDT 2018


stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, labath, zturner.
Herald added a subscriber: llvm-commits.

1. In logtest.cpp, the name of the file that is reported is not always capitalized, so split the comparison to validate the file (case insensitive) and function (case sensitive) separately
2. Update the gdb remote client tests to work with Python 3. In Python 3, socket sends/receives data as bytes rather than byte strings. This also updates the usage of .hex() - this is no longer available in Python 3, so use hexlify instead


Repository:
  rL LLVM

https://reviews.llvm.org/D46773

Files:
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py
  unittests/Utility/LogTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46773.146405.patch
Type: text/x-patch
Size: 4945 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180511/82db33db/attachment.bin>


More information about the llvm-commits mailing list