[llvm] r331897 - llvm-mca: Add missing includes

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Fri May 11 12:25:33 PDT 2018


Good point - something felt a bit off about that.

Done in r332124

On Fri, May 11, 2018 at 12:07 PM Craig Topper <craig.topper at gmail.com>
wrote:

> Shouldn't includes of STL be listed last?
>
>
> ~Craig
>
>
> On Wed, May 9, 2018 at 10:31 AM David Blaikie via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: dblaikie
>> Date: Wed May  9 10:28:10 2018
>> New Revision: 331897
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=331897&view=rev
>> Log:
>> llvm-mca: Add missing includes
>>
>> Move the header include in the primary source file to the top to
>> validate that it doesn't depend on any other inclusions.
>>
>> Modified:
>>     llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp
>>     llvm/trunk/tools/llvm-mca/RetireControlUnit.h
>>
>> Modified: llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp?rev=331897&r1=331896&r2=331897&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp (original)
>> +++ llvm/trunk/tools/llvm-mca/RetireControlUnit.cpp Wed May  9 10:28:10
>> 2018
>> @@ -1,5 +1,5 @@
>> -#include "Dispatch.h"
>>  #include "RetireControlUnit.h"
>> +#include "Dispatch.h"
>>  #include "llvm/MC/MCSchedule.h"
>>  #include "llvm/Support/Debug.h"
>>
>>
>> Modified: llvm/trunk/tools/llvm-mca/RetireControlUnit.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/RetireControlUnit.h?rev=331897&r1=331896&r2=331897&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/tools/llvm-mca/RetireControlUnit.h (original)
>> +++ llvm/trunk/tools/llvm-mca/RetireControlUnit.h Wed May  9 10:28:10 2018
>> @@ -15,6 +15,10 @@
>>  #ifndef LLVM_TOOLS_LLVM_MCA_RETIRE_CONTROL_UNIT_H
>>  #define LLVM_TOOLS_LLVM_MCA_RETIRE_CONTROL_UNIT_H
>>
>> +#include <algorithm>
>> +#include <vector>
>> +
>> +#include "Instruction.h"
>>  #include "llvm/MC/MCSchedule.h"
>>
>>  namespace mca {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180511/41c089c3/attachment.html>


More information about the llvm-commits mailing list