[PATCH] D46672: COFF: ICF a section and its associated pdata section as a unit.
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 11 11:22:20 PDT 2018
smeenai added inline comments.
================
Comment at: lld/COFF/ICF.cpp:141
+ };
+ return ChildClasses(A) == ChildClasses(B);
+}
----------------
Is there a possibility of ChildClasses(A) and ChildClasses(B) having the same contents but in a different order? Would we want to ICF in that case? (Since right now the == is going to be doing an ordered comparison.)
https://reviews.llvm.org/D46672
More information about the llvm-commits
mailing list