[PATCH] D46760: [InstCombine] Enhance narrowUDivURem.

Bixia Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 11 10:55:19 PDT 2018


bixia marked an inline comment as done.
bixia added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineMulDivRem.cpp:948
+
+  if (CanConvert) {
     // If the constant is the same in the smaller type, use the narrow version.
----------------
lebedev.ri wrote:
> I'd guess it would be simpler to use early return.
I don't quite understand how to do that without duplication the code inside if (CanConvert)? Can you some detail?


Repository:
  rL LLVM

https://reviews.llvm.org/D46760





More information about the llvm-commits mailing list