[PATCH] D46752: [InstCombine] Validate the assumption about return type in optimizeSnPrintFString

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

I haven't looked in detail at the failure or discussion in https://reviews.llvm.org/D46285 or https://bugs.llvm.org/show_bug.cgi?id=37408 , so I might be missing something.
Why are we getting this far in the 1st place? Shouldn't we have avoided this problem in TargetLibraryInfoImpl::isValidProtoForLibFunc() by checking that the return type is wrong?


Repository:
  rL LLVM

https://reviews.llvm.org/D46752