[PATCH] D46748: [CodeGen/AccelTable]: Handle -dwarf-linkage-names=Abstract correctly

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 11 05:16:04 PDT 2018


labath created this revision.
labath added reviewers: probinson, aprantl, JDevlieghere.

If we are not emitting a linkage name in the .debug_info sections, we
should not add it into the index either. This makes sure our index is
consistent with the actual debug info.

I am also explicitly setting the --dwarf-linkage-names=All in the
name-collsions test as that one would now fail on targets where this
defaults to "Abstract" (in fact, it would have failed already if there
wasn't a bug in the DWARF verifier, which I fix as well).


Repository:
  rL LLVM

https://reviews.llvm.org/D46748

Files:
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/DebugInfo/DWARF/DWARFVerifier.cpp
  test/DebugInfo/Generic/debug-names-linkage-name.ll
  test/DebugInfo/Generic/debug-names-name-collisions.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46748.146308.patch
Type: text/x-patch
Size: 7080 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180511/d01a22d4/attachment.bin>


More information about the llvm-commits mailing list