[PATCH] D46502: [ELF] - Fix for "LLD can create incorrect debug PC ranges for functions in Comdat groups."

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D46502#1095707, @peter.smith wrote:

> I suggest asking on the PR as that had quite a few people involved in debug generation on the CC list. They may have a better view on how important it is for a linker to fix up the relocations or not.


Yes. That what I wanted to do (had issues with VPN as for Russia bugs.llvm.org and svn just does not work without it atm. That's annoying.). Done.

> A possible alternative, that I haven't thought through fully, that might not require the creation of a proxy section is for each selected group store the tuple <Group Signature Name (as we do today), InputFile*, Group Section Index in InputFile>. With this information could we look up the selected InputSection and store it in Sections[] rather than a proxy section. This would mean having an InputSection from Object A in the Sections array for Object B which could have some unforeseen side effects.

Side effects are a concern here. When I experimented with approaches for this patch, I tried different solutions, but side effects were annoying.
Also, such way is less isolated and also not clear if we want to change the design of the linker so much for this hack. Let's see the possible comments.


https://reviews.llvm.org/D46502