[PATCH] D46709: [Dominators] Add PDT constructor from Function

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 11 02:27:34 PDT 2018


kuhar added a comment.

We can also try to refactor other places in the codebase that first construct PDT and then immediately do PDT.recalculate(F).



================
Comment at: unittests/IR/DominatorTreeBatchUpdatesTest.cpp:25
 
-struct PostDomTree : PostDomTreeBase<BasicBlock> {
-  PostDomTree(Function &F) { recalculate(F); }
-};
+using PostDomTree = PostDominatorTree;
 
----------------
I think it would be better to replace all uses od `PostDomTree` with PostDominatorTree


================
Comment at: unittests/IR/DominatorTreeTest.cpp:24
 
-struct PostDomTree : PostDomTreeBase<BasicBlock> {
-  PostDomTree(Function &F) { recalculate(F); }
-};
+using PostDomTree = PostDominatorTree;
 
----------------
Same as above.


Repository:
  rL LLVM

https://reviews.llvm.org/D46709





More information about the llvm-commits mailing list