[PATCH] D46681: [AArch64][SVE] Extend parsing of Prefetch operation for SVE.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 11 01:32:52 PDT 2018
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:2085
Operands.push_back(AArch64Operand::CreatePrefetch(
- prfop, PRFM ? PRFM->Name : "", S, getContext()));
+ prfop, PRFM ? *PRFM : "", S, getContext()));
return MatchOperand_Success;
----------------
nit: As we are using Optional, something like `PRFM.getValueOr("") `would be slightly more explicit IMO
https://reviews.llvm.org/D46681
More information about the llvm-commits
mailing list