[PATCH] D46285: [InstCombine] snprintf optimizations

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 10 14:27:26 PDT 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D46285#1094989, @xbolva00 wrote:

> In https://reviews.llvm.org/D46285#1094917, @mstorsjo wrote:
>
> > This caused lots of assertion errors in building code with mingw-w64 headers (where snprintf can be a static inline function), see https://bugs.llvm.org/show_bug.cgi?id=37408. I would like to revert this change to unbreak things until this can be fixed.
>
>
> C standard says:
>  int snprintf(char * restrict s, size_t n, const char * restrict format, ...);


Yes, but that's not an argument for making the compiler trigger a failed assertion if faced with code that doesn't exactly comply with it. Reverted until this issue is fixed.


Repository:
  rL LLVM

https://reviews.llvm.org/D46285





More information about the llvm-commits mailing list