[PATCH] D45647: Limit the MaxSteps used in hasPredessorHelper

[Tom Rix via Phabricator via llvm-commits]

trixirt added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13264
     if (SDNode::hasPredecessorHelper(StoreNodes[i].MemNode, Visited, Worklist,
-                                     Max))
+                                     SDNode::hasPredecessorHelperMaxSteps()))
       return false;
----------------
rogfer01 wrote:
> I'm not sure to understand the whole change: doesn't this call return always compute 32*4 - 4?
> 
> If so, why using a function in the first place instead of adjusting `Max` above?
The input parameter controls the max level, so it is tunable.


Repository:
  rL LLVM

https://reviews.llvm.org/D45647