[PATCH] D46666: [libFuzzer] Experimental data flow tracer for fuzz targets.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc marked 2 inline comments as done.
kcc added inline comments.


================
Comment at: lib/fuzzer/dataflow/DataFlow.cpp:59
+"Li j k": describes the label 'i' as a union of labels 'j' and 'k'.
+"Ff l": tells that the function 'f' depends on the label 'l'.
+//===----------------------------------------------------------------------===*/
----------------
morehouse wrote:
> Nit:  Why mix `//` comment style with `/* ... */`?
This is actually a /* comment, see the first line. 
Agree, with // it looks nicer, fixed. 


================
Comment at: lib/fuzzer/dataflow/DataFlow.cpp:183
+void __dfsw___sanitizer_cov_trace_switch(uint64_t Val, uint64_t *Cases,
+                                         dfsan_label L1) {
+  assert(CurrentFunc < NumFuncs);
----------------
morehouse wrote:
> Does DFSan require a second label here since there's 2 parameters in the original signature?
The second label will be inserted, but I don't need it, since Cases is a constant. 
Added a parameter called UnusedL just for clarity. 


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D46666