[PATCH] D46502: [ELF] - Fix for "LLD can create incorrect debug PC ranges for functions in Comdat groups."

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

In https://reviews.llvm.org/D46502#1094633, @ruiu wrote:

> > My understanding is that it depends on what action the debugger is trying to do. If it is single-stepping through a function from the selected comdat group there will be at least one set of .debug sections that have the correct PC range so mappings from Address to Source will work. The difficulty is with the Source to Address mapping for the objects where the group was discarded. For example show me all the symbols defined in this source file will not find the comdat group as the PC range won't be correct.
>
> I don't know if showing all symbols defined by some file is a common operation. Is it?


I've no idea to be honest, I suspect it would be more common in GUI based debuggers that have a speedbar containing all the files in a program than in something like gdb. It isn't just that operation though; it is anything that requires the debugger to look up something starting at a source location. For example setting breakpoints based on source file and line.


https://reviews.llvm.org/D46502