[PATCH] D46628: [ELF] Add --strip-debug-non-line option

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 10 10:01:15 PDT 2018


grimar added a comment.

In https://reviews.llvm.org/D46628#1094613, @aprantl wrote:

> If dwarfdump can't find a problem with the output (and there is a problem with it) then that's a bug in dwarfdump. If you want to do functional testing, you'll probably want to pipe the result through something like llvm-symbolizer or lldb as an end-to-end test.




> In fact running that on the output of this new option resulted in errors, so I'll address those.

If I correctly understood the case, then it means that dwarfdump was able to find problems, but looks it does not like the new output. In that case, fixing/updating the dwarfdump and then using it for this patch looks reasonable to me.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46628





More information about the llvm-commits mailing list