[PATCH] D46693: lld-link: Add --color-diagnostics(={always, never, auto})?, --no-color-diagnostics flags.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Is there any reason to make it exactly the same option name as Unix linkers? I mean, all the other options in the COFF linker are Windows-ish, e.g. /something. So I wonder if /colordiagnostics{,:always,:never,:auto} is better.



================
Comment at: lld/COFF/DriverUtils.cpp:766
+    return;
+  else if (Arg->getOption().getID() == OPT_color_diagnostics)
+    errorHandler().ColorDiagnostics = true;
----------------
nit: no else after return.


================
Comment at: lld/COFF/DriverUtils.cpp:770
+    errorHandler().ColorDiagnostics = false;
+  else {
+    StringRef S = Arg->getValue();
----------------
nit: consistently add {} if you add {} to some `else` or `else if`.


https://reviews.llvm.org/D46693