[PATCH] D46193: [LSR] Skip LSR if the cost of input is cheaper than LSR's solution
Krzysztof Parzyszek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 10 07:23:00 PDT 2018
kparzysz added inline comments.
================
Comment at: test/Transforms/LoopStrengthReduce/AArch64/skip-lsr-solution.ll:1
+; RUN: llc < %s -mtriple=aarch64 -lsr-insns-cost=true -debug-only=loop-reduce 2>&1 | FileCheck %s
+
----------------
sebpop wrote:
> kparzysz wrote:
> > This needs "REQUIRES: asserts".
> I don't see any CHECK statement depending on -debug-only, so instead of requiring asserts, let's just remove that flag.
>
> Also please remove the other flag: -lsr-insns-cost=true as I see that its default value is true:
>
> "lsr-insns-cost", cl::Hidden, cl::init(true),
>
It's there, the first CHECK line: `CHECK: Skip using LSR's solution`.
https://reviews.llvm.org/D46193
More information about the llvm-commits
mailing list